3 tests fail on FreeBSD

[yurivict]

Describe the bug

See log.

To Reproduce
Testsuite.

Environment (please complete the following information):

• OS and Version: FreeBSD 13.2
• jq version: 1.7

[ncfavier]

AFAICT this is a locale problem: strptime is returning the wrong day of the week (3 instead of 4), which could mean that the current locale's first_weekday is different from the expected locale's first_weekday. jq should set the locale it expects explicitly in tests to avoid this.

[nicowilliams]

Oh, yes, now that jq calls setlocale() we need to maybe not set it when running tests, or else set it to the C locale.

[nicowilliams]

The workaround is to run LC_ALL=C TZ= make check.

[yurivict]

The workaround is to run LC_ALL=C TZ= make check.

This workaround doesn't solve the problem.

When we run: /usr/bin/env LC_ALL=C TZ= gmake -f Makefile check
we see that the same tests are still failing:

Test #1: '[strptime("%Y-%m-%dT%H:%M:%SZ")|(.,mktime)]' at line number 4
*** Expected [[2015,2,5,23,51,47,4,63],1425599507], but got [[2015,2,5,23,51,47,3,63],1425599507] for test at line number 6: [strptime("%Y-%m-%dT%H:%M:%SZ")|(.,mktime)]
Test #2: 'last(range(365 * 67)|("1970-03-01T01:02:03Z"|strptime("%Y-%m-%dT%H:%M:%SZ")|mktime) + (86400 * .)|strftime("%Y-%m-%dT%H:%M:%SZ")|strptime("%Y-%m-%dT%H:%M:%SZ"))' at line number 11
*** Expected [2037,1,11,1,2,3,3,41], but got [2037,1,11,1,2,3,2,41] for test at line number 13: last(range(365 * 67)|("1970-03-01T01:02:03Z"|strptime("%Y-%m-%dT%H:%M:%SZ")|mktime) + (86400 * .)|strftime("%Y-%m-%dT%H:%M:%SZ")|strptime("%Y-%m-%dT%H:%M:%SZ"))
Test #3: 'strftime("%A, %B %e, %Y")' at line number 16
1 of 3 tests passed (0 malformed, 0 skipped)
FAIL tests/optionaltest (exit status: 1)

[yurivict]

@nicowilliams

Any chance to fix tests?

[wader]

@yurivict does #3039 make it better? or is TZ= also needed?

[yurivict]

No, the latest revision 913b264 still has 3 failing tests.

[wader]

@emanuele6 set TZ also for tests?

[yurivict]

Earlier I tried with LC_ALL=C TZ= but it didn't help either.

[wader]

@yurivict doh sorry i misread your earlier comment