Improve loading speed for image cards #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork to match current version of source repository
Sync to parent repo
Sync to master repo
jsbroks
reviewed
Nov 2, 2019
backend/database/images.py
Outdated
|
|
||
| # Calculate resize ratio: | ||
| resize_ratio = min(1, self.MAX_THUMBNAIL_DIM[0] / pil_image.height, | ||
| self.MAX_THUMBNAIL_DIM[1] / pil_image.width) |
There was a problem hiding this comment.
I think we can simplify this by using PIL.Image.thumbnail
There was a problem hiding this comment.
Yeah, you're right. I can make the changes on Monday and update the pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current loading speeds of the dataset page can be quite slow when using high resolution images. This greatly improves loading speed for image cards on dataset page by resizing and compressing thumbnail images to a maximum allowable image size. It also uses this smaller thumbnail image for both annotated and non-annotated images.