Implement proposal for file URL path normalisation#170
Merged
domenic merged 4 commits intojsdom:masterfrom Sep 30, 2020
Merged
Conversation
domenic
requested changes
Sep 29, 2020
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
LGTM, but marking as "request changes" just so that I don't forget to update the get-latest-platform-tests.js before merging. (I'll be happy to do that myself, once the spec/tests land; no further action needed from you.) Thanks so much for your work!
annevk
pushed a commit
to whatwg/url
that referenced
this pull request
Sep 30, 2020
Applicable only to file URLs: - Leading empty path segments are no longer removed. - If absent, the host is copied from the base URL. - Otherwise the host is preserved with one exception: if the host is `localhost`, then it is set to the empty string. Tests: web-platform-tests/wpt#25716. JS implementation: jsdom/whatwg-url#170. Fixes #302 and fixes #402.
domenic
approved these changes
Sep 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the proposal for file URL path normalisation, as discussed in whatwg/url#405
(!!) Please note that this pins the tests to a specific commit in my fork of the web platform tests.
This should be updated if these changes are accepted, see web-platform-tests/wpt#25716