Exclude transitive ASM dependency #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need the bean mapping features and it causes issues Fixes json-path#228, json-path#224, json-path#213
|
Of course, that would break user that tries to use the bean mapping dependencies from json-smart. It's not an ideal solution. Maybe we should rather jarjar the asm classes. |
|
No, ignore the last comment. The classes are still there when excluding the transitive |
jochenberger
changed the title
|
On the other hand, maybe we should rather follow netplex/json-smart-v2#35 and exclude the ASM classes from |
|
We would have to republish the |
jochenberger
changed the title
This was referenced Mar 21, 2017
cmunilla
pushed a commit
to cmunilla/JPath
that referenced
this pull request
Oct 30, 2017
Exclude transitive ASM dependency
jon-wei
pushed a commit
to apache/druid
that referenced
this pull request
Jun 15, 2018
* Update JSONPath Library Re: #5792 - Add a unit test containing a JSONPath conditional - Update the JSONPath library and no longer exclude the json-smart dependency. - I believe the original reason for excluding this has been fixed: json-path/JsonPath#315 * Add test * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need the bean mapping features and it causes issues
Fixes #228, #224, #213