Skip to content

Conversation

@heysujal
Copy link
Contributor

What kind of change does this PR introduce?
This PR adds a new entry in data/case-studies.json for the missing Cookpad case study

Issue Number: #1159

Screenshots/videos:

image

Does this PR introduce a breaking change?

No

@heysujal heysujal requested a review from a team as a code owner December 17, 2024 20:26
@heysujal
Copy link
Contributor Author

Please provide feedback if the summary written for this case study needs to be updated.

@github-actions
Copy link

github-actions bot commented Dec 17, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview d704c9d

@DhairyaMajmudar
Copy link
Member

Thank you Ben for the review @heysujal pls. commit the suggestions made by him and merge the latest changes with the main to your branch it will fix the failing workflow.

@codecov
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (27398a9) to head (d704c9d).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1176   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this!

I notice the Cookpad logo looks stretched.
The image itself isn't, so this is a CSS issue. It will need to be fixed =]

benjagm
benjagm previously approved these changes Dec 20, 2024
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I'll approve as soon as the last changes are done.

@benjagm benjagm self-requested a review December 20, 2024 16:04
@benjagm benjagm dismissed their stale review December 20, 2024 16:05

More changes needed.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. I just added the style required to fix it.

@benjagm benjagm merged commit 6a20417 into json-schema-org:main Dec 21, 2024
9 checks passed
@heysujal
Copy link
Contributor Author

@benjagm Thanks a lot for the style fix. When I first made this PR, I noticed the issue and tried to fix it using other CSS property but couldn't make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cookpad case study missing from case study page

4 participants