Skip to content

Updated PR body validation workflow #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2025

Conversation

Utkarsh-123github
Copy link
Member

What kind of change does this PR introduce?
This PR basically updates the previous approach of referencing issues with a new one that supports:

  • All types of official GitHub-recognized keywords for issue references which includes :
    close
    closes
    closed
    fix
    fixes
    fixed
    resolve
    resolves
    resolved
  • Full URLs to issues (not just the # 1234 format).

Issue Number:

Summary
Update the PR Body Validation workflow to accept:

  • Full URLs to issues (not just the # 1234 format).
  • Any of the official GitHub-recognized keywords for issue references.

This would make PR validation consistent with GitHub’s own behavior and reduce friction for contributors who use the full range of supported formats.

Does this PR introduce a breaking change?
No

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@Utkarsh-123github Utkarsh-123github requested a review from a team as a code owner June 26, 2025 04:08
Copy link

github-actions bot commented Jun 26, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 920aee7

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (547dcf2) to head (920aee7).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1741   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          448       448           
  Branches       116       116           
=========================================
  Hits           448       448           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Utkarsh-123github
Copy link
Member Author

Hi @Relequestual , I have made the requested changes in the PR body validation workflow. Kindly review it and suggest some changes if applicable at your convenience.
Thank You!

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@benjagm benjagm merged commit da172f7 into json-schema-org:main Jun 28, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Ready to review to Done in PR - Triage Group Jun 28, 2025
@Utkarsh-123github Utkarsh-123github deleted the pr-body-fix branch July 5, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Allow full Issue URLs and all GitHub recognized Issue reference keywords in PR body validation
2 participants