-
-
Notifications
You must be signed in to change notification settings - Fork 3
feat: adds initial configuration code #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated
|
Hey @yowainwright nice changes to the repo. Sorry for the delay to catchup on this. Changes look good, but i don't understand the use of |
|
Looking good, can we drop this too from github actions https://codesee.io |
@JayaKrishnaNamburu done! |
Nice, let me know when you are done with the tests and stuff. We can merge this 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the awesome work @yowainwright 🎉
Really appreciate it 😄
Description
This pull request adds initial configuration code.
Configurations added
EditorconfigBunwill remove to match jspm patternsSetup Config bash (bin/setup.sh)went with devcontainers onlyLint-stagedwill remove to match jspm patterns,Todos
devcontainer
+bin/setup.sh
loader.ts
Discussion
After discussion I will implement a function with tests for
extractPackageNameAndVersion
. 👌Thank you!!! 🎈🎈🎈