Skip to content

feat: adds initial configuration code #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 28, 2023

Conversation

yowainwright
Copy link
Member

@yowainwright yowainwright commented Mar 30, 2023

Description

This pull request adds initial configuration code.

Everything is implemented for discussion!!! 🙂

Configurations added

  • Chomp!
  • Vitest
  • Eslint
  • Prettier
  • Editorconfig
  • Devcontainers
  • Bun will remove to match jspm patterns
  • Typescript
  • Commitlint
  • Setup Config bash (bin/setup.sh) went with devcontainers only
  • Husky
  • Lint-staged will remove to match jspm patterns,

Todos

  • add chomp to devcontainer + bin/setup.sh
  • prefer chomp over npm scripts (seems like that's the pattern)
  • fully test loader.ts

Discussion

After discussion I will implement a function with tests for extractPackageNameAndVersion. 👌

  • Happy to break out pieces that are desired. 👍
  • Happy to remove pieces that are not. 👍

Thank you!!! 🎈🎈🎈

@yowainwright yowainwright marked this pull request as ready for review March 31, 2023 09:25
@yowainwright
Copy link
Member Author

yowainwright commented Mar 31, 2023

Updated

  • Feel free to check it out!
  • Happy to change whatever!
  • I will write tests in a bit—which means I will test the end-to-end stuff then! 😄

@JayaKrishnaNamburu
Copy link
Member

Hey @yowainwright nice changes to the repo. Sorry for the delay to catchup on this. Changes look good, but i don't understand the use of devcontainers and the setup.sh files. And if you are ok, can we drop the .editorconfig ?

@yowainwright
Copy link
Member Author

yowainwright commented Apr 18, 2023

  • @JayaKrishnaNamburu removed /bin, .editorconfig.

  • Wrote doc for running the devcontainer. Let me know your thoughts!

  • Will wrap tests ASAP!

@JayaKrishnaNamburu
Copy link
Member

Looking good, can we drop this too from github actions https://codesee.io

@yowainwright
Copy link
Member Author

@JayaKrishnaNamburu done!

@JayaKrishnaNamburu
Copy link
Member

Nice, let me know when you are done with the tests and stuff. We can merge this 👍

Copy link
Member

@JayaKrishnaNamburu JayaKrishnaNamburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the awesome work @yowainwright 🎉
Really appreciate it 😄

@JayaKrishnaNamburu JayaKrishnaNamburu merged commit 21fd0b1 into jspm:main Apr 28, 2023
@yowainwright yowainwright deleted the init-config-code branch August 24, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants