Skip to content

feat: adds easier testing support ⚡️ #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 61 commits into from
Aug 22, 2023

Conversation

yowainwright
Copy link
Member

@yowainwright yowainwright commented May 26, 2023

Proposed Changes

This PR is largely a refactor for better testing.

  • Reorganizes code for testability

Read about referenced issues here. Replace words with this Pull Request's context.

@guybedford
Copy link
Member

@yowainwright feel free to ping myself or @JayaKrishnaNamburu again for review when you're ready.

@yowainwright yowainwright marked this pull request as ready for review August 5, 2023 07:09
@yowainwright yowainwright changed the title feature: Adds easier testing support feature: Adds easier testing support ⚡️ Aug 5, 2023
@yowainwright yowainwright changed the title feature: Adds easier testing support ⚡️ feat: Adds easier testing support ⚡️ Aug 5, 2023
@yowainwright yowainwright changed the title feat: Adds easier testing support ⚡️ feat: adds easier testing support ⚡️ Aug 5, 2023
@JayaKrishnaNamburu JayaKrishnaNamburu self-requested a review August 22, 2023 17:01
Copy link
Member

@JayaKrishnaNamburu JayaKrishnaNamburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @yowainwright, works as expected. And let's release it and make some examples to share online 😄 😉

@JayaKrishnaNamburu JayaKrishnaNamburu merged commit ee8f214 into jspm:main Aug 22, 2023
@yowainwright yowainwright deleted the update-import-map-location branch August 24, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants