Skip to content

[Fix] jsx-key: detect missing keys in logical expressions #3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yalperg
Copy link

@yalperg yalperg commented Jun 6, 2025

Fix: #3931

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.80%. Comparing base (f2869fd) to head (7b2bcab).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3932      +/-   ##
==========================================
- Coverage   97.84%   97.80%   -0.04%     
==========================================
  Files         136      133       -3     
  Lines       10008     9999       -9     
  Branches     3717     3717              
==========================================
- Hits         9792     9780      -12     
- Misses        216      219       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yalperg yalperg force-pushed the fix/js-key/logical-expression branch from 2849ab3 to 1cb9049 Compare June 6, 2025 21:17
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: react/jsx-key rule doesn't detect missing keys in LogicalExpression in return statements
2 participants