HOTFIX Move escaping comma to 'def escape_userdn_if_needed' #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @LLluma, This fix just moves the breakage I introduced inside a function, but it's not appropriate there either as the regex was only intended to be applied to the CN attribute where all commas need to be escaped. I've pushed a fix in #83 which I hope should work for everyone. In the absence of a test suite to catch these things early I resolve to at least fix breakages as quickly as I'm able to! |
|
Version 1.2.2 has been published to pypi - please let me know if that fixes the problem for you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for bug #79 (Authentication against Active directory stopped working)