#742 Support Lyrics from LRC files and User Input #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ality for LRC files
…nd new LyricsPage view
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4 to 5. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-java dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [org.springframework.boot:spring-boot-starter-parent](https://github.com/spring-projects/spring-boot) from 3.5.4 to 3.5.5. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.5.4...v3.5.5) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-starter-parent dependency-version: 3.5.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…s/setup-java-5' into issue742-replace-lyrics-source-to-lrc
…work.boot-spring-boot-starter-parent-3.5.5' into issue742-replace-lyrics-source-to-lrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #742
This pull request introduces several improvements and refactorings to the lyrics handling functionality, as well as updates to CI workflow configurations. The most significant changes are the refactoring of the lyrics-related classes and controllers to support lyrics persistence, improved security checks, and simplification of the lyrics API. Additionally, all GitHub Actions workflows have been updated to use the latest version of the Java setup action.
Lyrics functionality refactor and enhancements:
LyricsInfotoLyricsStatusinairsonic-main/src/main/java/org/airsonic/player/ajax/LyricsStatus.java, removing unused fields and addingpersisted/tryLaterflags to better represent lyrics fetch and persistence status. [1] [2]LyricsWSControllerto use dependency injection for services, improved security checks, and changed the lyrics fetch API to persist lyrics when possible. The response now usesLyricsStatusand supports saving lyrics to media files. [1] [2] [3] [4] [5]LyricsControllerto use dependency injection, provide lyrics view/edit/update endpoints, and ensure lyrics are only accessible/modified if the user has access to the media file. [1] [2]SubsonicRESTControllerto useLyricsServicedirectly for lyrics lookup and removed dependency on the oldLyricsWSController. Lyrics are now retrieved and returned if available, based on artist/title and user music folders. [1] [2] [3] [4]CI/CD workflow updates:
actions/setup-java@v5instead of@v4for Java setup, ensuring compatibility with the latest Java build tools and improved reliability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]