Add CI/CD with GitHub Actions #249
Conversation
devoto13
left a comment
devoto13
left a comment
There was a problem hiding this comment.
LGTM
Couple of non-blocking nits to consider.
jginsburgn
requested review from
devoto13
and removed request for
devoto13 and
mtrea
devoto13
left a comment
devoto13
left a comment
There was a problem hiding this comment.
chore seems to be allowed with the latest changes though...
Done! Sorry for the delay. |
|
BTW, let me also fix the commit types |
Except for updating contributors, which remains in Grunt. #243
Also: * Remove the "pretest" npm script as it is explicitly called in the "Test" GitHub Actions workflow. * Allow for the "chore" commit type as it is used by the grunt "contributors" task.
This will ensure that the recent CI/CD Release workflow with GitHub Actions is working properly.
mtrea
left a comment
mtrea
left a comment
There was a problem hiding this comment.
Please consider adding some documentation along with this. I'm sure GitHub has their own "Actions" doc, but consider whether there's anything Karma-specific that contributors might need to know (copy-pastable command to run tests, where to view results, how to rerun tests, etc).
@mtrea please check the latest commit :) |
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
Also, migrate from Grunt to Semantic Release and do a general cleanup.
Resolves #242 #243