Skip to content

Conversation

liangyuanpeng
Copy link
Contributor

the PR also need it:
#101

# github.com/go-openapi/swag
Error: ../../../go/pkg/mod/github.com/go-openapi/[email protected]/string_bytes.go:7:29: undefined: unsafe.StringData
note: module requires Go 1.20
FAIL	kcl-lang.io/kcl-openapi/pkg/cmds [build failed]
FAIL	kcl-lang.io/kcl-openapi/pkg/kube_resource/generator [build failed]
FAIL	kcl-lang.io/kcl-openapi/pkg/swagger/generator [build failed]
Error: Process completed with exit code 2.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy
Copy link
Contributor

Peefy commented Aug 19, 2024

Thank you! LGTM

@Peefy Peefy merged commit faa14db into kcl-lang:main Aug 19, 2024
@liangyuanpeng liangyuanpeng deleted the upgrade_go_1.20 branch August 19, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants