Skip to content

[Bug] on dataset change: this._rows[e] is undefined #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ritesh9876
Copy link
Contributor

Steps to reproduce:
1.Select two datasets where at least one column is common, but the number of rows differs.

  1. In a layer, remove some columns.

  2. Change the dataset for the layer.

  3. Check the console for errors.

Root Cause:
Kepler.gl's colorField, sizeField, and similar properties continue referencing fields from the previously used dataset. Since the datasets have different row counts, these fields attempt to access indices beyond the length of the previous dataset, causing the error when index > firstDataset.rows.length.

sameple_2.csv
sample_1.csv
dataset_changed_undefined.webm

@Ritesh9876
Copy link
Contributor Author

Hii @igorDykhta @heshan0131
Just checking in, would you have a moment to take a quick look at this PR?
If it's not something you'd like to move forward with, feel free to let me know and I can close it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant