Factor out exclusion flags into a separate struct #189
Conversation
dtcaciuc
changed the title
dtcaciuc
changed the title
main.go
Outdated
| if *ignore != "" { | ||
| fmt.Fprintf(os.Stderr, "error: -ignore flag is deprecated, please use -exclude and/or -ignorepkg instead") | ||
| return nil, exitFatalError | ||
| } |
There was a problem hiding this comment.
Can you alias -ignore to another flag, or trivially transform it somehow?
There was a problem hiding this comment.
I don't see how I can do it without adding a special field to Exclusions struct. I tried making a special case in logic that processes Exclusions.Packages, however for that, -ignore would had to treat the absence of :<regexp>portion at the end of each of the strings in the list as just the package name, whereas it does entirely the opposite: it assumes entire string is the regexp per https://github.com/kisielk/errcheck/blob/master/main.go#L46
There was a problem hiding this comment.
My concern is that it would break peoples' workflows to make this change. I know that it's been deprecated, but I feel that we should keep it, or go to 2.0.
There was a problem hiding this comment.
Functionality restored, PTAL
I've taken the liberty of modifying the incoming changes somewhat. The UpdateNonVendoredIgnore function has been renamed, unexported, and made to return data instead of setting it.
errcheck/errcheck.go
Outdated
|
|
||
| // Verbose causes extra information to be output to stdout. | ||
| Verbose bool | ||
| // Symbols lists regular expression patterns that exclude package symbols. |
There was a problem hiding this comment.
Hold on a second... these are not regular expressions
errcheck/errcheck.go
Outdated
| // getNonVendoredIgnores gets the ignore expressions for non-vendored packages. | ||
| // They are returned as a map from package path names to '.*' regular | ||
| // expressions. | ||
| func (c *Checker) getNonVendoredIgnores() map[string]*regexp.Regexp { |
There was a problem hiding this comment.
This could be a standalone function that takes []string since the only dependency it uses is c.Exclusions.Packages
There was a problem hiding this comment.
Refactored; this function was dissolved altogether.
Independent of whether go mod is used or not, simply strip off vendor directory prefix from both imports and excludes if it was found.
Simplify vendored package resolution.
No description provided.