Remove CheckPaths #193
Merged
Remove CheckPaths #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the CheckPaths method of Checker. It also adds a method called LoadPackages, and exports more of the logic that errcheck uses to do aggregation. The UncheckedErrors type has been renamed to Result, and the CheckPackage function now returns a *Result instead of []UncheckedErrors. Signed-off-by: Eric Chlebek <[email protected]>
kisielk
reviewed
Oct 25, 2020
kisielk
reviewed
Oct 25, 2020
kisielk
reviewed
Oct 25, 2020
Signed-off-by: Eric Chlebek <[email protected]>
Signed-off-by: Eric Chlebek <[email protected]>
Signed-off-by: Eric Chlebek <[email protected]>
dtcaciuc
reviewed
Oct 26, 2020
As suggested by dtcaciuc Signed-off-by: Eric Chlebek <[email protected]>
Signed-off-by: Eric Chlebek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the CheckPaths method of Checker. It also
adds a method called LoadPackages, and exports more of the logic
that errcheck uses to do aggregation.
The UncheckedErrors type has been renamed to Result, and the
CheckPackage function now returns a *Result instead of
[]UncheckedErrors.
Signed-off-by: Eric Chlebek [email protected]