Add SelectorName in UncheckedError

[SVilgelm]

Added a SelectorName field in the UncheckedError struct to store the original func name.

We cannot integrate the errchecker linter with the golangci-lint tool without this changes, we have an additional exclude of os.Stdout|Stderr.Write, but the fullName function returns (*os.File).Write and ignoring os.File is not acceptable.

[SVilgelm]

@kisielk Could you please review this? One more attempt to integrate with golangci-lint

[kisielk]

Looks good to me. Would you mind also adding a test to the test suite?

[SVilgelm]

Looks good to me. Would you mind also adding a test to the test suite?

sure, will add

[SVilgelm]

@kisielk I added a very simple test, that the original line should contain the selectorName. Is it good enough?

[kisielk]

That is ok for now I think. The tests need a bit of a revamp to look for the specific test data anyway.. Let me check with the other maintainers if this change is ok then we can merge.

[SVilgelm]

Thanks

[dtcaciuc]

Basically what Kamil already said, current check seems more like a smoke test, but doesn't look like we can do much more without involved refactoring. LGTM

[SVilgelm]

we can write a test to test only the selectorName function, but I didn't;t figure out how to properly create the ast Tree to cover all cases. I will try to work on it

[kisielk]

@SVilgelm I wouldn't worry about it for now, I don't really want to test un-exported functions, we just need to go through and restructure the existing tests.

[SVilgelm]

@kisielk @dtcaciuc thank you! It works fine: golangci/golangci-lint#1319
Could you please release a new version?

[kisielk]

I've tagged v1.6.0