Audio features#253
Open
susmit wants to merge 4 commits into
Open
Conversation
KeyWeeUsr
suggested changes
Jan 12, 2017
|
|
||
| self.update_labels() | ||
|
|
||
| def pause_activity(): |
Contributor
There was a problem hiding this comment.
_activity? Activiry is mainly used in p4a in the meaning Android Activity. This will be just confusing.
| size_hint_y: None | ||
| height: sp(40) | ||
| text: 'Recording Location: ' + str(root.audio.file_path) | ||
|
|
Contributor
There was a problem hiding this comment.
why? it looks more readable if you separate widgets like that, especially if you have a lot of properties.
Contributor
Author
|
I have tested the pr and is working fine.The pr is ready.Below are the screenshots of its working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the audio recorder has only start and stop functionality.I have introduced pause and resume functionality in it.
State description:
Note:- The pr is not in mergeable state bcz testing is due and removal of pep8 errors.