[coinbase-pro] Updating/Adding support for some AccountService and TradeService endpoints. #4763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dpoints and some for TradeService endpoints.
…dated so that it returns currency on the "transfers" endpoints. So, not need to make 1 extra call in order to compare accountId with currency.
…rt for instruments in userTrades.
…oint. Change some String fields to enums in CoinbaseProCurrency and CoinbaseProProduct
…aseProMarketDataService
…ause it is possible that this feature will be needed for other exchanges also i have put the main creator class in core module.
…ause it is possible that this feature will be needed for other exchanges also i have put the main creator class in core module.
…Data to CoinbaseProBaseService
…ataService interfaces
… into bybit-implementation
…futures,options). Adding support for BybitStreamingExchange with getUserTrades Observable as the first supported websocket stream
# Conflicts: # xchange-coinbasepro/src/main/java/org/knowm/xchange/coinbasepro/CoinbaseProAdapters.java
Member
|
Would you please fix the branch conflicts? Then I will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.