Skip to content

Send use_non_positive_negative_number_constrained_types to the data type manager #2425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

torarvid
Copy link

Fixes #2424

@torarvid torarvid changed the title Send use_non_positive_negative_number_constrained_types to the datamodel Send use_non_positive_negative_number_constrained_types to the data type manager Jun 17, 2025
Copy link
Collaborator

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test to validate change.

@gaborbernat gaborbernat marked this pull request as draft June 17, 2025 15:21
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (0886c0e) to head (addf4bb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2425   +/-   ##
=======================================
  Coverage   98.12%   98.13%           
=======================================
  Files          66       66           
  Lines        8231     8246   +15     
  Branches      823      827    +4     
=======================================
+ Hits         8077     8092   +15     
  Misses        115      115           
  Partials       39       39           
Flag Coverage Δ
unittests 98.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

codspeed-hq bot commented Jun 17, 2025

CodSpeed Performance Report

Merging #2425 will not alter performance

Comparing torarvid:push-tuzwuwxzqvmp (addf4bb) with main (cb7ee07)

Summary

✅ 32 untouched benchmarks

@torarvid torarvid force-pushed the push-tuzwuwxzqvmp branch from 622532a to addf4bb Compare June 18, 2025 08:02
@torarvid
Copy link
Author

@gaborbernat I added a test 👍🏼

@torarvid torarvid marked this pull request as ready for review June 30, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag --use-non-positive-negative-number-constrained-types doesn't work when generating Pydantic v2 classes
2 participants