fix: set-labels handle slice, change log#892
Merged
yuwenma merged 57 commits intokptdev:masterfrom Aug 4, 2022
Merged
Conversation
…ll slice type and denote slice type in common.go
…ffinity.podAffinity.preferredDuringSchedulingIgnoredDuringExecution[].podAffinityTerm.labelSelector.matchLabels" & "spec.template.spec.affinity.podAffinity.requiredDuringSchedulingIgnoredDuringExecution[].labelSelector.matchLabels" & "spec.template.spec.affinity.podAntiAffinity.preferredDuringSchedulingIgnoredDuringExecution[].podAffinityTerm.labelSelector.matchLabels" & "spec.template.spec.affinity.podAntiAffinity.requiredDuringSchedulingIgnoredDuringExecution[].labelSelector.matchLabels" & "spec.template.spec.topologySpreadConstraints[].labelSelector.matchLabels" for ReplicationController & ReplicaSet & DaemonSet & Job & CronJob
yuwenma
reviewed
Jul 28, 2022
yuwenma
reviewed
Aug 1, 2022
Contributor
|
The new format is much better! I think it's a good starting point to help us improving the SDK and make the |
natasha41575
reviewed
Aug 1, 2022
natasha41575
approved these changes
Aug 2, 2022
Contributor
natasha41575
left a comment
natasha41575
left a comment
There was a problem hiding this comment.
Code structure LGTM, defer to @yuwenma for final approval
yuwenma
approved these changes
Aug 4, 2022
Contributor
|
This PR looks great! This is a good starting point to let us continue improving the SDK and adding features. like the OpenApi schema as @natasha41575 suggested. |
zyy98
changed the title
set-labels feature change, handle slice, change logset-labels handle slice, change log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more paths that contain slice in
SubObjectafter double checking the kubernetes source code, and refactor that part of slice processing after discussion with Yuwen.The current code removes the common
FieldSpec, and processes each transformation according to the KRM resource the object belong to.change log to show general information to avoid being truncated.