🐛 Fix/generate go apis target

[LucaLanziani]

/kind bug

What this PR does / why we need it:

This fixes the wrong behavior where running make generate after an api change wont regenerate the CRD definitions.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3336

Special notes for your reviewer:

1. make clean
2. change the API definition
3. make generate
4. change the API definition again
5. make generate

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

[k8s-ci-robot]

@LucaLanziani: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @LucaLanziani. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Ankitasw]

/ok-to-test

[Ankitasw]

Special notes for your reviewer:

1. make clean
2. change the API definition
3. make generate
4. change the API definition again
5. make generate

@LucaLanziani Any reason why we have to run make generate twice?

[LucaLanziani]

@Ankitasw The problem presented itself on the second run, the first run the generate will work because the clean target.
So to reproduce the problem a first make generare is needed to bring the project to the "dirty" state.

As also explained here:

#3336 (comment)

[Ankitasw]

/lgtm

[Ankitasw]

cc @richardcase for review.

[richardcase]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment