Skip to content

✨ Prevent users setting values that are invalid configuration on AWS#4656

Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
giantswarm:validate-spot-mixed-instances
Nov 28, 2023
Merged

✨ Prevent users setting values that are invalid configuration on AWS#4656
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
giantswarm:validate-spot-mixed-instances

Conversation

@fiunchinho
Copy link
Copy Markdown
Contributor

@fiunchinho fiunchinho commented Nov 23, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Users can currently set both SpotMarketOptions and MixedInstancesPolicy, but this is not a valid configuration on AWS, resulting on this error

InvalidQueryParameter: Incompatible launch template: You cannot use a launch template that is set to request Spot Instances (InstanceMarketOptions) when you configure an Auto Scaling group with a mixed instances policy. Add a different launch template to the group and try again.

It's better to prevent this configuration early, so users get quick feedback on what's wrong with their clusters.

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Prevent users setting SpotMarketOptions and MixedInstancesPolicy at the same time

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Nov 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 23, 2023
AndiDog
AndiDog reviewed Nov 23, 2023
View reviewed changes
@fiunchinho @AndiDog
Update exp/api/v1beta2/awsmachinepool_webhook.go
99ddc99 
Co-authored-by: Andreas Sommer <andreas@giantswarm.io>
AndiDog
AndiDog reviewed Nov 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@AndiDog AndiDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2023
@fiunchinho fiunchinho mentioned this pull request Nov 23, 2023
Closed
@richardcase
Copy link
Copy Markdown
Member

richardcase commented Nov 25, 2023

/test ?

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 25, 2023

@richardcase: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-main
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-clusterclass
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks
  • /test pull-cluster-api-provider-aws-e2e-eks-gc
  • /test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-main
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@richardcase
Copy link
Copy Markdown
Member

richardcase commented Nov 25, 2023

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Copy Markdown
Member

richardcase commented Nov 28, 2023

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit b4506f8 into kubernetes-sigs:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndiDog AndiDog AndiDog left review comments

@Ankitasw Ankitasw Awaiting requested review from Ankitasw

+1 more reviewer

@faiq faiq faiq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AndiDog AndiDog

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fiunchinho @richardcase @k8s-ci-robot @AndiDog @faiq