Skip to content

🐛 Don't error if ASG is missing when deciding to refresh instances#4660

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
giantswarm:no-error-missing-asg-instance-refresh
Nov 28, 2023
Merged

🐛 Don't error if ASG is missing when deciding to refresh instances#4660
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
giantswarm:no-error-missing-asg-instance-refresh

Conversation

@fiunchinho
Copy link
Copy Markdown
Contributor

@fiunchinho fiunchinho commented Nov 27, 2023 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Avoid erroring when ASG does not exist when deciding to refresh instances.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4655

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Don't error when ASG is not present while deciding whether or not to refresh ASG instances.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 27, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 27, 2023
@fiunchinho
Copy link
Copy Markdown
Contributor Author

fiunchinho commented Nov 27, 2023

/test ?

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 27, 2023

@fiunchinho: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-main
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-clusterclass
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks
  • /test pull-cluster-api-provider-aws-e2e-eks-gc
  • /test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-main
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fiunchinho
Copy link
Copy Markdown
Contributor Author

fiunchinho commented Nov 27, 2023

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@cnmcavoy
Copy link
Copy Markdown
Contributor

cnmcavoy commented Nov 27, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2023
@kundan2707
Copy link
Copy Markdown

kundan2707 commented Nov 28, 2023

/lgtm

@richardcase
Copy link
Copy Markdown
Member

richardcase commented Nov 28, 2023

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 25f8108 into kubernetes-sigs:main Nov 28, 2023
@fiunchinho fiunchinho mentioned this pull request Nov 28, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ankitasw Ankitasw Awaiting requested review from Ankitasw

1 more reviewer

@luthermonson luthermonson luthermonson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cnmcavoy cnmcavoy

@kundan2707 kundan2707

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AWSMachinePool reconciliation stuck if ASG could not be created

6 participants

@fiunchinho @k8s-ci-robot @cnmcavoy @kundan2707 @richardcase @luthermonson