:bug: cleanup: eliminate log spam when using S3 secrets by thefirstofthe300 · Pull Request #4667 · kubernetes-sigs/cluster-api-provider-aws

thefirstofthe300 · 2023-11-29T03:36:25Z

/kind cleanup

Currently, the S3 object store generates a large amount of log spam during reconciliation. Objects are stated to be deleting regardless of objects already being deleted.

Example:

I1129 02:23:28.008345       1 logger.go:67] "Deleting unneeded entry from AWS S3" secretPrefix=""
I1129 02:23:28.008394       1 logger.go:67] "Deleting object" controller="awsmachine" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="AWSMachine" AWSMachine="clusters-system/us-west-2-production-worker-us-west-2d-infra-vln7r-xzcsk" namespace="clusters-system" name="us-west-2-production-worker-us-west-2d-infra-vln7r-xzcsk" reconcileID="c10cc649-57ce-40f4-99bb-17d06590c2cf" machine="clusters-system/us-west-2-production-worker-us-west-2d-5lgbh-6cbb9999d5xlnxtcvd" cluster="clusters-system/us-west-2-production" bucket_name="cluster-api-provider-aws-gremlin-us-west-2-production" key="node/us-west-2-production-worker-us-west-2d-infra-vln7r-xzcsk"
I1129 02:24:05.691604       1 awsmanagedcluster_controller.go:114] "Successfully reconciled AWSManagedCluster" controller="awsmanagedcluster" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="AWSManagedCluster" AWSManagedCluster="clusters-system/us-east-1-production-testing" namespace="clusters-system" name="us-east-1-production-testing" reconcileID="8cbaa551-85ef-4feb-9fac-533577193662" cluster="us-east-1-production-testing" controlPlane="us-east-1-production-testing-control-plane"

Release note:

If you're using S3 buckets for bootstrap data, the following permissions are required on the controller to automatically detect whether an object is still needing to be deleted: `s3:GetObject`. The following permissions are optional: `s3:ListBucket`.

k8s-ci-robot · 2023-11-29T03:36:35Z

Hi @thefirstofthe300. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/cloud/services/s3/s3.go

pkg/cloud/services/s3/s3_test.go

controllers/awsmachine_controller.go

pkg/cloud/services/s3/s3.go

vincepri · 2023-11-29T21:32:55Z

/ok-to-test

vincepri · 2023-11-29T21:33:01Z

/test ?

k8s-ci-robot · 2023-11-29T21:33:04Z

@vincepri: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build
/test pull-cluster-api-provider-aws-test
/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main
/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-blocking
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e-conformance
/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-eks-gc
/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main
pull-cluster-api-provider-aws-build
pull-cluster-api-provider-aws-test
pull-cluster-api-provider-aws-verify

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vincepri · 2023-11-29T21:33:29Z

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-blocking
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e-conformance
/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-eks-gc
/test pull-cluster-api-provider-aws-e2e-eks-testing

AndiDog

One compatibility blocker. Rest looks fine.

pkg/cloud/services/s3/s3.go

For upcoming feature kubernetes-sigs/cluster-api-provider-aws#4667

thefirstofthe300 · 2024-01-08T22:27:28Z

/retest

Ankitasw · 2024-01-10T08:26:44Z

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

Ankitasw · 2024-01-11T08:12:03Z

/approve

cc @AndiDog for another review

k8s-ci-robot · 2024-01-11T08:12:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Ankitasw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

AndiDog · 2024-01-11T17:21:10Z

/lgtm

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Nov 29, 2023

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 29, 2023

k8s-ci-robot requested review from faiq and vincepri November 29, 2023 03:38

AndiDog reviewed Nov 29, 2023

View reviewed changes

pkg/cloud/services/s3/s3.go Outdated Show resolved Hide resolved

pkg/cloud/services/s3/s3_test.go Outdated Show resolved Hide resolved

thefirstofthe300 force-pushed the reduce-log-spam branch from 212ce90 to 16eba48 Compare November 29, 2023 19:31

vincepri reviewed Nov 29, 2023

View reviewed changes

controllers/awsmachine_controller.go Outdated Show resolved Hide resolved

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 29, 2023

thefirstofthe300 force-pushed the reduce-log-spam branch from 16eba48 to 0e6b5dd Compare November 29, 2023 19:40

vincepri reviewed Nov 29, 2023

View reviewed changes

pkg/cloud/services/s3/s3.go Outdated Show resolved Hide resolved

thefirstofthe300 force-pushed the reduce-log-spam branch from 0e6b5dd to ca2cae6 Compare November 29, 2023 19:42

thefirstofthe300 requested review from AndiDog and vincepri November 29, 2023 20:26

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 29, 2023

AndiDog reviewed Dec 8, 2023

View reviewed changes

pkg/cloud/services/s3/s3.go Outdated Show resolved Hide resolved

AndiDog added a commit to giantswarm/giantswarm-aws-account-prerequisites that referenced this pull request Dec 8, 2023

Add s3:GetObject permission for CAPA

a8d084c

For upcoming feature kubernetes-sigs/cluster-api-provider-aws#4667

AndiDog mentioned this pull request Dec 8, 2023

Add s3:GetObject permission for CAPA giantswarm/giantswarm-aws-account-prerequisites#85

Merged

AndiDog added a commit to giantswarm/giantswarm-aws-account-prerequisites that referenced this pull request Dec 8, 2023

Add s3:GetObject permission for CAPA

222b2f6

For upcoming feature kubernetes-sigs/cluster-api-provider-aws#4667

AndiDog added a commit to giantswarm/giantswarm-aws-account-prerequisites that referenced this pull request Dec 11, 2023

Add s3:GetObject permission for CAPA (#85)

ee7bbf7

For upcoming feature kubernetes-sigs/cluster-api-provider-aws#4667

thefirstofthe300 force-pushed the reduce-log-spam branch from ca2cae6 to abb23b7 Compare January 8, 2024 22:19

cleanup: eliminate log spam when using S3 secrets

0be00ee

thefirstofthe300 force-pushed the reduce-log-spam branch from abb23b7 to 0be00ee Compare January 8, 2024 22:30

thefirstofthe300 requested a review from AndiDog January 8, 2024 22:51

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024

k8s-ci-robot assigned AndiDog Jan 11, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2024

k8s-ci-robot merged commit 2234387 into kubernetes-sigs:main Jan 11, 2024

thefirstofthe300 deleted the reduce-log-spam branch January 11, 2024 18:50

Conversation

thefirstofthe300 commented Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Nov 29, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vincepri commented Nov 29, 2023

Uh oh!

vincepri commented Nov 29, 2023

Uh oh!

k8s-ci-robot commented Nov 29, 2023

Uh oh!

vincepri commented Nov 29, 2023

Uh oh!

AndiDog left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thefirstofthe300 commented Jan 8, 2024

Uh oh!

Ankitasw commented Jan 10, 2024

Uh oh!

Ankitasw commented Jan 11, 2024

Uh oh!

k8s-ci-robot commented Jan 11, 2024

Uh oh!

AndiDog commented Jan 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

thefirstofthe300 commented Nov 29, 2023 •

edited

Loading