🐛 fix: s3 bucket in us-east-1 should not set location constraint

[mtulio]

What type of PR is this?

/kind bug

What this PR does / why we need it:

The following error is raised when creating a cluster in us-east-1:

E0229 16:32:03.857522 2077184 co[1]ntroller.go:329] "Reconciler error" err=<
	failed to reconcile S3 Bucket for AWSCluster openshift-cluster-api-guests/mrb-capa-00-gr9m7: ensuring bucket exists: creating S3 bucket: InvalidLocationConstraint: The specified location-constraint is not valid
		status code: 400, request id: 3QSJFBYM9H60N3D6, host id: 
 > controller="awscluster" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="AWSCluster" AWSCluster="openshift-cluster-api-guests/mrb-capa-00-gr9m7" namespace="openshift-cluster-api-guests" name="mrb-capa-00-gr9m7" reconcileID="f6b8a66c-108b-4988-9047-0151511fb5bd" 

The location constraint must be null when creating buckets in the region us-east-1.

"Buckets in Region us-east-1 have a LocationConstraint of null."[1]

[1] https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketLocation.html#API_GetBucketLocation_ResponseSyntax

Which issue(s) this PR fixes

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• includes emojis
• adds unit tests
• adds or updates e2e tests

Release note:

Skip location constraint configuration when creating a bucket on `us-east-1`.

[k8s-ci-robot]

Welcome @mtulio!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @mtulio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Ankitasw]

@mtulio thanks for this PR. This has not yet caught in our CI coz CI uses region=us-west-2
Could you update the release notes so that we can merge this PR?

[mtulio]

PTAL?
/assign @vincepri @Ankitasw

[vincepri]

/ok-to-test

what an edge case 😄

[vincepri]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment