🐛 Fix subtests running in same environment and reconciliation bug which was not covered because of that#5048
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Jul 11, 2024
Conversation
… was not covered because of that
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
lgtm
Contributor
|
Thanks! /approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlipovetsky The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
I was the author of those tests. They shared one envtest and namespace by mistake, leading to conflicts. After fixing this, luckily, only one new problem appeared which the conflicting tests previously couldn't catch: the reconciliation would return after setting
AWSMachinePool.status.launchTemplateVersion, but can just continue (else we would have to call 3xreconcileNormalin the test to make it all happen). One test was checking for something it didn't even need (again:AWSMachinePool.status.launchTemplateVersion).Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):n/a
Special notes for your reviewer: n/a
Checklist:
Release note: