Skip to content

✨ Adding devbox and devcontainer configuration#5301

Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
faermanj:add-devbox-with-devcontainer
Jan 22, 2025
Merged

✨ Adding devbox and devcontainer configuration#5301
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
faermanj:add-devbox-with-devcontainer

Conversation

@faermanj
Copy link
Copy Markdown
Contributor

@faermanj faermanj commented Jan 21, 2025 •
edited by richardcase
Loading

/kind support

What this PR does / why we need it:

Adds devbox so that the project can be built and executed on any machine.
Adds devcontainer so that anyone on github can build and execute the project using codespaces.

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add devbox and devcontainer configuration

@k8s-ci-robot k8s-ci-robot added kind/support Categorizes issue or PR as a support question. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jan 21, 2025
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 21, 2025

Hi @faermanj. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 21, 2025
@faermanj faermanj mentioned this pull request Jan 21, 2025
Closed
@damdo
Copy link
Copy Markdown
Member

damdo commented Jan 21, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 21, 2025
@richardcase
Copy link
Copy Markdown
Member

richardcase commented Jan 21, 2025

/release-note-edit Add devbox and devcontainer configuration

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 21, 2025
@richardcase
Copy link
Copy Markdown
Member

richardcase commented Jan 21, 2025

/test pull-cluster-api-provider-aws-test

richardcase
richardcase reviewed Jan 21, 2025
View reviewed changes
devbox.json Outdated
{
"$schema": "https://raw.githubusercontent.com/jetify-com/devbox/0.13.7/.schema/devbox.schema.json",
"packages": [
"go",
Copy link
Copy Markdown
Member

@richardcase richardcase Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pin the version of go to same version from go.mod?

Copy link
Copy Markdown
Contributor Author

@faermanj faermanj Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds better, I'll add.

@richardcase
Copy link
Copy Markdown
Member

richardcase commented Jan 22, 2025

Thanks for this @faermanj

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit ac6d032 into kubernetes-sigs:main Jan 22, 2025
@richardcase
Copy link
Copy Markdown
Member

richardcase commented Jan 22, 2025

/cherrypick release-2.7
/cherrypick release-2.6

@richardcase
Copy link
Copy Markdown
Member

richardcase commented Jan 22, 2025

Cherry picked as this will be useful for any patching on release branches

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Jan 22, 2025

@richardcase: new pull request created: #5316

Details

In response to this:

/cherrypick release-2.7
/cherrypick release-2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 22, 2025
Merged
@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Jan 22, 2025

@richardcase: new pull request created: #5317

Details

In response to this:

/cherrypick release-2.7
/cherrypick release-2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 22, 2025
Merged
@faermanj faermanj mentioned this pull request Jan 22, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardcase richardcase richardcase left review comments

@damdo damdo Awaiting requested review from damdo

@fiunchinho fiunchinho Awaiting requested review from fiunchinho

Assignees

@richardcase richardcase

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@faermanj @k8s-ci-robot @damdo @richardcase @k8s-infra-cherrypick-robot