🐛 Use different names for controllers watching AWSCluster objects

[AndiDog]

What type of PR is this?

This fixes startup errors

"unable to create controller" err="controller with name awscluster already exists. Controller names must be unique to avoid multiple controllers reporting to the same metric" logger="setup" controller="AWSControllerIdentity"

which I believe come from using latest cluster-api or controller-runtime which I had for locally running E2E tests. Since this might hit us when bumping CAPI or other components, I thought we can already fix it now.

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• includes emoji in title
• adds unit tests
• adds or updates e2e tests

Release note:

Use different names for controllers watching `AWSCluster` objects

[fiunchinho]

/lgtm

[richardcase]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[AndiDog]

Hmm, works for me locally. Trying again.

/test pull-cluster-api-provider-aws-test