Skip to content

⚠️ templates: use NLB as Control Plane Load Balancer type#5345

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
damdo:update-templates-to-use-nlbs
Feb 19, 2025
Merged

⚠️ templates: use NLB as Control Plane Load Balancer type#5345
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
damdo:update-templates-to-use-nlbs

Conversation

@damdo
Copy link
Copy Markdown
Member

@damdo damdo commented Feb 11, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR changes the type of loadbalancer used for controlPlane to NLB (Network Load Balancer) in the templates for CAPA.
This change is necessary in supporting k8s >= 1.30 since the AWS Classic Load Balancer has been deprecated for a while, and starting from K8s 1.30, the cyphersuite required by go to interact with the Classic LB has been removed. See #5139 for more details and reasoning.

Release note:

templates: start explicitly using NLB (Network Load Balancer) + HTTPS checks for the Control Plane Load Balancer

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 11, 2025
@k8s-ci-robot k8s-ci-robot added needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2025
@damdo
Copy link
Copy Markdown
Member Author

damdo commented Feb 11, 2025

@richardcase do we also need to upgrade the clusterClass templates? If so, do you have any guidance on how to do that? Thanks!

@damdo damdo changed the title templates: use NLB as controlPlane loadbalancer ⚠️ templates: use NLB as controlPlane loadbalancer Feb 11, 2025
@damdo damdo changed the title ⚠️ templates: use NLB as controlPlane loadbalancer ⚠️ templates: use NLB as Control Plane Load Balancer type Feb 11, 2025
@damdo
Copy link
Copy Markdown
Member Author

damdo commented Feb 11, 2025

@richardcase
Copy link
Copy Markdown
Member

@damdo - we will have to update the clusterclass templates as well. Will ping you later today to discuss.

@damdo damdo force-pushed the update-templates-to-use-nlbs branch from 83f39bf to 0e95b2b Compare February 11, 2025 11:37
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2025
@damdo
Copy link
Copy Markdown
Member Author

damdo commented Feb 11, 2025

@richardcase updated ClusterClass templates too now.

@richardcase
Copy link
Copy Markdown
Member

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@richardcase
Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4e912b4 into kubernetes-sigs:main Feb 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants