⚠️ templates: use NLB as Control Plane Load Balancer type#5345
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Feb 19, 2025
Merged
⚠️ templates: use NLB as Control Plane Load Balancer type#5345k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
Member
Author
|
@richardcase do we also need to upgrade the clusterClass templates? If so, do you have any guidance on how to do that? Thanks! |
Member
Author
This was referenced Feb 11, 2025
Member
|
@damdo - we will have to update the clusterclass templates as well. Will ping you later today to discuss. |
83f39bf to
0e95b2b
Compare
Member
Author
|
@richardcase updated ClusterClass templates too now. |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
This was referenced May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR changes the type of loadbalancer used for controlPlane to NLB (Network Load Balancer) in the templates for CAPA.
This change is necessary in supporting k8s >= 1.30 since the AWS Classic Load Balancer has been deprecated for a while, and starting from K8s 1.30, the cyphersuite required by go to interact with the Classic LB has been removed. See #5139 for more details and reasoning.
Release note: