fix: make sure machine pools are deleted before gke cluster#1458
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Apr 23, 2025
Merged
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2aefcfa to
7abfdae
Compare
Contributor
Author
damdo
reviewed
Apr 5, 2025
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
7abfdae to
59a24be
Compare
Member
|
This is great, thanks @salasberryfin /approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev, richardcase, salasberryfin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
During cluster deletion, a
GCPManagedClustermay be deleted before its associatedGCPManagedMachinePool/s which actually needs the cluster resource to exist to delete successfully:This happens intermittently and it's hard to reproduce, but there needs to be logic that waits for the machine pools to be removed before continuing with deleting the cluster.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is similar to this CAPA issue.
TODOs:
Release note: