Bump and adopt golangci-lint v2 #2404
Merged
+415
−363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/provider/ibmcloud
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
kishen-v
commented
Jun 27, 2025
| text: "ST1003: should not use underscores in Go names;" | ||
| path: .*(api|types)\/.*\/.*conversion.*\.go$ | ||
| - linters: | ||
| - staticcheck |
There was a problem hiding this comment.
⚠️ Mergestaticcheck,stylecheck,gosimpleinto one linter (staticcheck) (cf. Migration guide)
kishen-v
commented
Jun 27, 2025
| @@ -495,7 +495,7 @@ docker-build-core-image: ensure-buildx ## Build the multiarch core docker image | |||
|
|
|||
| .PHONY: lint | |||
| lint: $(GOLANGCI_LINT) ## Lint codebase | |||
| $(GOLANGCI_LINT) run -v --fast=false | |||
| $(GOLANGCI_LINT) run -v --fast-only=false | |||
There was a problem hiding this comment.
fast -> fast-only:
https://golangci-lint.run/product/migration-guide/#lintersfast
kishen-v
commented
Jun 27, 2025
| @@ -214,7 +214,7 @@ type Passwd struct { | |||
|
|
|||
| // PasswdGroup holds the PasswdGroup specific information. | |||
| type PasswdGroup struct { | |||
| Gid *int `json:"gid,omitempty"` //nolint:stylecheck | |||
| Gid *int `json:"gid,omitempty"` //nolint:staticcheck | |||
There was a problem hiding this comment.
stylecheck is now clubbed under staticcheck
Prajyot-Parab
requested changes
Jun 30, 2025
kishen-v
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
kishen-v
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
lgtm
|
/cc @Amulyam24 |
Prajyot-Parab
approved these changes
Jun 30, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Amulyam24, kishen-v, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adopts the usage of golangci-lint tool(v2) from the existing v1, which is unmaintained. This will allow the latest available features and enhancements to be used associated with the v2 release.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2360
Special notes for your reviewer:
I'd ensured that most of the existing functionalities and checks are in place. Please let me know if additional changes are needed.
/area provider/ibmcloud
/priority important-longterm
/kind cleanup
Release note: