✨ Make packages related to in-place updates public#13507
Open
alexander-demicev wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
✨ Make packages related to in-place updates public#13507alexander-demicev wants to merge 1 commit intokubernetes-sigs:mainfrom
alexander-demicev wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
do-not-merge/needs-area
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
|
|
||
| // copySpec overwrites patched.destSpecPath with modified.srcSpecPath. | ||
| fieldsToPreserve := make([]patchutil.Path, len(patchOptions.preserveFields)) | ||
| for i, p := range patchOptions.preserveFields { |
Contributor
Author
There was a problem hiding this comment.
I added this conversion to avoid changes here https://github.com/kubernetes-sigs/cluster-api/blob/main/internal/contract/types.go#L32 but I can have it refactored too if needed in this PR or in a follow-up one.
Contributor
Author
|
/area util |
k8s-ci-robot
added
area/util
4 tasks
alexander-demicev
force-pushed
the
inplacehelperspublic
branch
5 times, most recently
from
526aafe to
3a4df53
Compare
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
alexander-demicev
force-pushed
the
inplacehelperspublic
branch
from
3a4df53 to
c445c4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR make ssome packages related to in-place update implementation public. We would to reuse them in CAPRKE2 to avoid re-implementing our own ones and stay aligned with kubeadm.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #