Add stats label filter test #1439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
saschagrunert
force-pushed
the
stats-filter
branch
from
b3c6d87 to
de14a6b
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
@kubernetes-sigs/cri-tools-maintainers PTAL |
Adding a conformance test for filtering stats by container labels. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
stats-filter
branch
from
de14a6b to
9990a76
Compare
Member
Author
|
Rebased to fix the CI. |
Member
|
/approve |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adding a conformance test for filtering stats by container labels.
Which issue(s) this PR fixes:
Refers to #448
Special notes for your reviewer:
Requires cri-o/cri-o#8240
Does this PR introduce a user-facing change?