Update documentation with missing features and fixes #1938
Merged
+28
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/documentation
k8s-ci-robot
added
approved
This commit updates the crictl and benchmark documentation to include missing features and fix inaccuracies: - Add missing runtime-config command to command list - Document OpenTelemetry tracing flags (--enable-tracing, --tracing-endpoint, --tracing-sampling-rate-per-million) - Document profiling flags (--profile-cpu, --profile-mem) - Add --list flag to config command documentation - Update statsp command description to match actual implementation - Update config command description to include "list" capability - Fix typo in benchmark.md: "Should help" -> "Show help" These changes ensure the documentation accurately reflects the current implementation and makes all features discoverable to users. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
update-documentation
branch
from
62d883f to
3931ed0
Compare
k8s-ci-robot
added
size/M
Member
Author
|
@kubernetes-sigs/cri-tools-maintainers PTAL |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This commit updates the crictl and benchmark documentation to include missing features and fix inaccuracies:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?