test(log): fix random race detection

[ivankatliarchuk]

Description

Resolves issues like this one #5268

Capturing both logs that behave differently not a great idea as it looks. At the moment we not testing klogs logs, so not loosing much.

If the problem persist, I debug more. Example next step to try similar stuff https://github.com/sirupsen/logrus/blob/master/internal/testutils/testutils.go, why we not using it, it's in internal package

Checklist

• Unit tests updated
• End user documentation updated

[ivankatliarchuk]

@mloiseleur wdyt? If is going to be flakey, I'll rewrite this test helper

[mloiseleur]

🤔 What led you to remove the condition here ?

[ivankatliarchuk]

As initial issue seems like is resolved. I'm saying seems as data races the hardest to resovle. The -race flag is a race detector, this condition was to trick -race detector

[ivankatliarchuk]

I could keep it, no harm

[mloiseleur]

Shouldn't the output reset to original value after ? (like a file or os.Stderr)
Anyway, it's better, but I'm not sure it will fix the issue.

Wdyt of this stack overflow example ?
An other way to do it would be to redirect log output to a file, and read it in one row, see for instance traefik integration test on acccess log.

[ivankatliarchuk]

Traefik integration test example will work, but it cover a case when there is a single logger. Exactly why I deleted klog from the intial function.

At the moment we not testing klog logs, for that we could have distinct function.

I agree with string, but not sure about paralel -race writes to file as IO is async, so not sure but we could try if problem still exist. The problelm with bytes.Buffer - is a slice where mutliple go routines could concurrently write to buffer

Shouldn't the output reset to original value after ?

Yes this is another option, aka buf.Reset().

Probably worth to re-run few times to validate that -race no longer catchin data races

[ivankatliarchuk]

Should solve

• https://github.com/kubernetes-sigs/external-dns/actions/runs/14438870293/job/40484641410?pr=5287 pr affected chore(crd): use conventional paths and update controller-gen to v0.17.2 #5287
• fix(helm): update helm schema #5297 (comment)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mloiseleur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mloiseleur]

/retitle test(log): fix random race detection