Skip to content

chore(provider/coredns): improve code coverage and reduce complexity#5456

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
gofogo:chore-quality-coredns-complexity
Jun 5, 2025
Merged

chore(provider/coredns): improve code coverage and reduce complexity#5456
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
gofogo:chore-quality-coredns-complexity

Conversation

@ivankatliarchuk
Copy link
Member

@ivankatliarchuk ivankatliarchuk commented May 23, 2025

What does it do ?

Improves code coverage for provider coredns, and reduce code complexity for certain functions

Motivation

Complexity from 27 to 10
Screenshot 2025-05-23 at 09 30 27

Before 66% coverage
Screenshot 2025-05-23 at 09 49 04

After 92% coverage

Screenshot 2025-05-23 at 12 25 07

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot requested review from mloiseleur and szuecs May 23, 2025 11:29
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 23, 2025
@ivankatliarchuk ivankatliarchuk force-pushed the chore-quality-coredns-complexity branch from 913f613 to 1c8a096 Compare May 23, 2025 11:31
@ivankatliarchuk ivankatliarchuk changed the title chore(provider/coredns): improve code coverage and reduce code comple… chore(provider/coredns): improve code coverage and reduce complexity May 23, 2025
@mloiseleur
Copy link
Collaborator

@linoleparquet @upsaurav12 Do you think you can review this PR ?

@upsaurav12
Copy link
Contributor

@linoleparquet @upsaurav12 Do you think you can review this PR ?

Sure !

Copy link
Contributor

@linolayani linolayani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good to me 👍

@k8s-ci-robot
Copy link
Contributor

@linoleparquet: changing LGTM is restricted to collaborators

Details

In response to this:

looking good to me 👍

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivankatliarchuk
Copy link
Member Author

@mloiseleur wdyt ok to be merged?

@upsaurav12
Copy link
Contributor

upsaurav12 commented Jun 5, 2025

looking good to me 👍

@mloiseleur
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: linoleparquet, mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2025
@mloiseleur
Copy link
Collaborator

Thanks @upsaurav12 and @linoleparquet

@k8s-ci-robot k8s-ci-robot merged commit ddeff34 into kubernetes-sigs:master Jun 5, 2025
14 checks passed
@ivankatliarchuk ivankatliarchuk deleted the chore-quality-coredns-complexity branch June 5, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants