chore(provider/coredns): improve code coverage and reduce complexity#5456
Conversation
913f613 to
1c8a096
Compare
|
@linoleparquet @upsaurav12 Do you think you can review this PR ? |
Sure ! |
|
@linoleparquet: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mloiseleur wdyt ok to be merged? |
|
looking good to me 👍 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: linoleparquet, mloiseleur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @upsaurav12 and @linoleparquet |
What does it do ?
Improves code coverage for provider coredns, and reduce code complexity for certain functions
Motivation
Complexity from 27 to 10

Before 66% coverage

After 92% coverage
More