chore(code-quality): reduce cyclomatic complexity of podSource.Endpoints()#5470
Conversation
fix nil pointer dereferences in podSource.Endpoints (kubernetes-sigs#5405)
|
Hi @vflaux. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
Shell we get that change in first? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivankatliarchuk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Flakey test https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_external-dns/5498/pull-external-dns-unit-test/1931039043810758656. Not sure related or not |
|
Fixes #5470 |
What does it do ?
Reduce cyclomatic complexity (30) of
podSource.Endpoints()insource/pod.go.Motivation
#5419
More