Skip to content

Conversation

mloiseleur
Copy link
Collaborator

@mloiseleur mloiseleur commented Jun 1, 2025

What does it do ?

It updates OWNERS file with a new maintainer: @ivankatliarchuk

Motivation

I ran monocle on external-dns for the last year with this config:

---
workspaces:
  - name: monocle
    crawlers:
      - name: github-external-dns
        provider:
          github_organization: kubernetes-sigs
          github_repositories:
            - external-dns
        update_since: '2024-06-01'

I saw on monocle that:

image

image

It seems to me that Ivan has clearly passed the requirements:

  • Reviewer of the codebase for at least 3 months
  • Primary reviewer for at least 10 substantial PRs to the codebase
  • Reviewed or merged at least 30 PRs to the codebase

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 1, 2025
@mloiseleur
Copy link
Collaborator Author

/assign @Raffo
/assign @szuecs

@mloiseleur
Copy link
Collaborator Author

@vflaux @mrozentsvayg @AndrewCharlesHay the stats in this PR may interest you.

If you are interested to follow the path to become an official maintainer, there is a starting point here: https://github.com/kubernetes/community/blob/master/community-membership.md

First, you have to find 2 sponsors among the maintainers and create an issue requesting membership of kubernetes-sigs in org repo: https://github.com/kubernetes/org

You can also review some PR, even without any rights.
Becoming a member of kubernetes-sigs org is the first step.

@Raffo
Copy link
Contributor

Raffo commented Jun 1, 2025

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2025
@AndrewCharlesHay
Copy link
Contributor

Congrats @ivankatliarchuk!

@szuecs
Copy link
Contributor

szuecs commented Jun 2, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2025
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2819c2f into kubernetes-sigs:master Jun 2, 2025
15 checks passed
@mloiseleur mloiseleur deleted the chore/update-maintainers branch June 2, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants