fix(f5): validate virtualservers and transportservers based on IP only

[mikejoh]

What does it do ?

This PR makes sure that we only validate the vsAddress field of a (F5 Networks) VirtualServer and TransportServer in the respective sources. Earlier we also checked the status field (and only passed through a VS/TS that had a status of ok). What we've realized is that a VirtualServer (or TransportServer) can end up in e.g. an error state which leaves the vsAddress intact.

More info here: F5Networks/k8s-bigip-ctlr#3723

This partially reverts: #4996.

I've updated the unit tests to reflect that we now only valide the presence of a valid IP address, regardless of the status field.

Motivation

More

• Yes, this PR title follows Conventional Commits
• Yes, I added unit tests
• Yes, I updated end user documentation accordingly

[k8s-ci-robot]

Hi @mikejoh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mloiseleur]

/ok-to-test
I'm unsure if it does not have side effects.

@visokoo Do you think you can review this PR ? Or at least share your thoughts on it ?

[mikejoh]

To elaborate a bit more on this change:

• VirtualServer and TransportServer have a lot in common, especially when it comes to how the F5 controller implements them. On a very high level a VS is working on Layer 7 and a TS on Layer 4. This is the reason why i'm touching the TransportServer code in this PR.
• In this PR https://github.com/F5Networks/k8s-bigip-ctlr/pull/3874/files#diff-61ccda86c7ff5845af9f1ea72a6dae37b52218669a5f38a79fe0eaf1752272cb the F5 devs fixed so that the IP address of a VS/TS is preserved regardless of the status. The problem we had were that if we had a config error in a object, all VS/TS (using the built-in IPAM solution) lost their IP addresses which in turn made the external-dns Source to exit early and eventually removing the DNS records of existing services when using the sync policy.

So the change i'm doing here is basically to accomodate for the fact that the IP is preserved regardless of the actual reported object (VS/TS) status.

[visokoo]

Thanks for linking the F5 PR for context. The change makes sense to me in terms of staying in line with the F5 PR, so LGTM.

[mloiseleur]

Thanks, it's clear.
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mloiseleur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment