test(awssd): fix a flaky test

[vflaux]

What does it do ?

Fix the flaky test TestAWSSDProvider_CreateService().

Use a deterministic ID when creating a service in the stub client to avoid random collision in s.service map (indexed by service ID).

external-dns/provider/awssd/fixtures_test.go

Line 74 in a4522f0

nsServices[*srv.Id] = srv

Motivation

 --- FAIL: TestAWSSDProvider_CreateService (0.00s)
    fixtures_test.go:264: 
        	Error Trace:	/home/prow/go/src/github.com/kubernetes-sigs/external-dns/provider/awssd/fixtures_test.go:264
        	            				/home/prow/go/src/github.com/kubernetes-sigs/external-dns/provider/awssd/aws_sd_test.go:497
        	Error:      	"map[1307:0xc0000f7340 7804:0xc0000f7180 9424:0xc0000f6fc0]" should have 4 item(s), but has 3
        	Test:       	TestAWSSDProvider_CreateService
FAIL

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_external-dns/5550/pull-external-dns-unit-test/1936508282768199680

Can be reproduce with (if you have luck):
go test --run 'TestAWSSDProvider_CreateService$' ./provider/awssd/ -count=10000; echo $?

More

• Yes, this PR title follows Conventional Commits
• Yes, I added unit tests
• Yes, I updated end user documentation accordingly

[k8s-ci-robot]

Hi @vflaux. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ivankatliarchuk]

/ok-to-test

[ivankatliarchuk]

not sure how this is about to solve a flakey test, but let's have a look

/lgtm

[mloiseleur]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mloiseleur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment