chore(cloudflare): use lib v4 for regional services

[vflaux]

What does it do ?

Migrate the regional services logic to the cloudflare lib v4.
We keep the old version for other parts (zone, custom hostnames, dns).

The v4 lib do not have the RegionalHostname struct so I redefined it (done in #5615).
I also introduce a function autoPagerIterator() to convert the v4 lib "AutoPager" to a go iterator.
This is used only once for now but it is intended to be used in other list calls.

There is no changes in the logic, simply a different api / structs.

Motivation

The current client is not supported anymore.
See #5540.

More

• Yes, this PR title follows Conventional Commits
• Yes, I added unit tests
• Yes, I updated end user documentation accordingly

[k8s-ci-robot]

Hi @vflaux. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ivankatliarchuk]

/ok-to-test

[vflaux]

smoke tests:

external-dns args

• --log-level=debug
• --log-format=json
• --events
• --source=ingress
• --provider=cloudflare
• --cloudflare-regional-services
• --cloudflare-region-key=

validation

GET on https://api.cloudflare.com/client/v4/zones/:zone_id/addressing/regional_hostnames

Cases

Create

Create new ingress with regional key to "eu".

Ingress:

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: test
  namespace: default
  annotations:
    external-dns.alpha.kubernetes.io/cloudflare-region-key: "eu"
spec:
  ingressClassName: cloudflare
  rules:
    - host: external-dns-test.xxx.xx
      http:
        paths:
          - path: /
            pathType: Prefix
            backend:
              service:
                name: test
                port:
                  name: http

Log:

{"action":"CREATE","hostname":"external-dns-test.xxx.xx","level":"debug","msg":"Creating regional hostname","region_key":"eu","time":"xxx","zone":"xxx"}

Cloudflare:

{
  "success": true,
  "errors": [],
  "result": [
    {
      "hostname": "external-dns-test.xxx.xx",
      "region_key": "eu",
      "created_on": "xxx"
    }
  ],
  "messages": []
}

Update

Update ingress with regional key "us".

Ingress:

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: test
  namespace: default
  annotations:
    external-dns.alpha.kubernetes.io/cloudflare-region-key: "us"

Log:

{"action":"UPDATE","hostname":"external-dns-test.xxx.xx","level":"debug","msg":"Updating regional hostname","region_key":"us","time":"xxx","zone":"xxx"}

Cloudflare:

{
  "success": true,
  "errors": [],
  "result": [
    {
      "hostname": "external-dns-test.xxx.xx",
      "region_key": "us",
      "created_on": "xxx"
    }
  ],
  "messages": []
}

Update

Delete ingress.

Log:

{"action":"DELETE","hostname":"external-dns-test.xxx.xx","level":"debug","msg":"Deleting regional hostname","region_key":"","time":"xxx","zone":"xxx"}

Cloudflare:

{
  "success": true,
  "errors": [],
  "result": [],
  "messages": []
}

[ivankatliarchuk]

Closes #5540

/lgtm

[mloiseleur]

Thanks.
There's still a long way to migrate other parts !

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mloiseleur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ivankatliarchuk]

Thanks.
There's still a long way to migrate other parts !
Indeed