-
Notifications
You must be signed in to change notification settings - Fork 2.8k
refactor(annotations): use common prefix to simplify filtering in informer transformers #5621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(annotations): use common prefix to simplify filtering in informer transformers #5621
Conversation
…transformers In order to filter annotations in informer transformers, this PR makes it more explicit that a common prefix is used. New prefixes can be added later-on if need be, but all annotations should be anchored in a known prefix. Signed-off-by: Valerian Roche <[email protected]>
Hi @valerian-roche. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mloiseleur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…transformers (kubernetes-sigs#5621) In order to filter annotations in informer transformers, this PR makes it more explicit that a common prefix is used. New prefixes can be added later-on if need be, but all annotations should be anchored in a known prefix. Signed-off-by: Valerian Roche <[email protected]>
This PR is extracted from #5595.
What does it do ?
In order to filter annotations in informer transformers, this PR makes it more explicit that a common prefix is used. New prefixes can be added later-on if need be, but all annotations should be anchored in a known prefix.
Motivation
This change should avoid addition of annotations mistakenly not matching expected patterns in informers.
There is no change otherwise
More
Yes, I added unit testsYes, I updated end user documentation accordingly