-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs: remove substitution in AES keygen examples #5686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove substitution in AES keygen examples #5686
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @fkaiegl! |
Hi @fkaiegl. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mloiseleur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does it do ?
This removes the substitution that replaces
+
and/
to-
and_
respectively from the documentation for example to generate AES (base64 encoded) encryption keys.Motivation
After testing these commands while wanting to introduce it, there was cases in which the commands effectively used the substitution. Go's
base64.StdEncoding.DecodeString
method does not want these substitutions, hence the keys will not work and ExternalDNS won't start.As mentioned in #5684; not sure if there was a reasoning behind this substitution.
Considering not every generation of a key with those commands result in the substitution being triggered, some generated keys effectively worked hence it may have been overlooked.
More
Yes, I added unit tests