Skip to content

Conversation

AndrewCharlesHay
Copy link
Contributor

@AndrewCharlesHay AndrewCharlesHay commented Oct 6, 2025

What does it do ?

Migrate customhostname to v5

Motivation

Closes #5540

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign szuecs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the provider Issues or PRs related to a provider label Oct 6, 2025
@k8s-ci-robot k8s-ci-robot requested a review from szuecs October 6, 2025 21:49
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 6, 2025
@coveralls
Copy link

coveralls commented Oct 6, 2025

Pull Request Test Coverage Report for Build 18312219767

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 72 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 78.52%

Files with Coverage Reduction New Missed Lines %
openshift_route.go 1 79.49%
cloudflare/cloudflare.go 71 89.73%
Totals Coverage Status
Change from base Build 18242454154: -0.03%
Covered Lines: 15806
Relevant Lines: 20130

💛 - Coveralls

Moved all tests from cloudflare_customhostname_test.go into cloudflare_test.go
to ensure proper coverage tracking by coveralls. Tests maintain 92.4% coverage.
@AndrewCharlesHay AndrewCharlesHay changed the title Andrewcharleshay/cloudflare migration v5 chore(cloudflare): migrate customhostname to v5 Oct 7, 2025
Co-authored-by: Michel Loiseleur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs provider Issues or PRs related to a provider size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudflare: bump library to v4
4 participants