Print generated GatewayClasses, TLSRoutes, TCPRoutes and ReferenceGrants.#110
Conversation
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/L
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
| for _, r := range gatewayResources { | ||
| resourceCount += len(r.GatewayClasses) | ||
| for _, gatewayClass := range r.GatewayClasses { | ||
| gatewayClass := gatewayClass | ||
| err := pr.resourcePrinter.PrintObj(&gatewayClass, os.Stdout) | ||
| if err != nil { | ||
| fmt.Printf("# Error printing %s GatewayClass: %v\n", gatewayClass.Name, err) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
It's just a nitpick, but is there any reason you repeated the outer for loop instead of having it once?
There was a problem hiding this comment.
Kept the original logic: print all gateways from all providers, then all HTTPRoutes etc.
If it's in one loop, then the logic would change and we'd print all resources per provider.
k8s-ci-robot
added
the
lgtm
|
/assign |
|
Thanks @dpasiukevich ! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dpasiukevich, levikobi, LiorLieberman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
Print generated GatewayClasses, TLSRoutes, TCPRoutes and ReferenceGrants.
These resources are already present in the provider conversion logic but are not propagated to the printer yet. The PR fixes this.
Which issue(s) this PR fixes:
Related to the #100. Istio provider would generate TLSRoutes, TCPRoutes and ReferenceGrants for users.
Does this PR introduce a user-facing change?: