Skip k8s client creation when reading local file.#128
Skip k8s client creation when reading local file.#128k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
|
/cc @LiorLieberman |
|
@dpasiukevich I think it also fixes #122 right? |
|
/hold for the controlled merge |
Yes, by the looks it should fix this issue as well. Let me double check that case later today and close that issue if it's the case. |
SG |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dpasiukevich, LiorLieberman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Make the tool more robust. Don't read/run k8s client config when reading local file. E.g. user may have incorrect/incompatible .kube_config but the user tries to convert a local file.
.kube_configfile should not affect the tool run in such case.I've checked all providers, none needs a k8sclient to translate a local file, which is expected.
Which issue(s) this PR fixes:
Fixes #127
Does this PR introduce a user-facing change?: