Skip to content

Skip k8s client creation when reading local file.#128

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
dpasiukevich:skip_client
Jan 31, 2024
Merged

Skip k8s client creation when reading local file.#128
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
dpasiukevich:skip_client

Conversation

@dpasiukevich
Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Make the tool more robust. Don't read/run k8s client config when reading local file. E.g. user may have incorrect/incompatible .kube_config but the user tries to convert a local file. .kube_config file should not affect the tool run in such case.

I've checked all providers, none needs a k8sclient to translate a local file, which is expected.

Which issue(s) this PR fixes:

Fixes #127

Does this PR introduce a user-facing change?:

Skip k8s client creation when reading local file.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 31, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 31, 2024
Copy link
Copy Markdown
Member

@levikobi levikobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dpasiukevich
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@levikobi
Copy link
Copy Markdown
Member

/cc @LiorLieberman

@LiorLieberman
Copy link
Copy Markdown
Member

@dpasiukevich I think it also fixes #122 right?

@dpasiukevich
Copy link
Copy Markdown
Contributor Author

/hold

for the controlled merge

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2024
@dpasiukevich
Copy link
Copy Markdown
Contributor Author

@dpasiukevich I think it also fixes #122 right?

Yes, by the looks it should fix this issue as well. Let me double check that case later today and close that issue if it's the case.

@LiorLieberman
Copy link
Copy Markdown
Member

Yes, by the looks it should fix this issue as well. Let me double check that case later today and close that issue if it's the case.

SG
/unhold
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dpasiukevich, LiorLieberman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9a5e08c into kubernetes-sigs:main Jan 31, 2024
xtineskim pushed a commit to xtineskim/ingress2gateway that referenced this pull request Apr 23, 2024
rajashish pushed a commit to rajashish/ingress2gateway1 that referenced this pull request Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tool fails to translate local file when there's incompatible .kube_config file

4 participants