Skip to content

feat: add a kubeconfig flag to specify kubeconfig file location #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Mar 4, 2024
Merged

feat: add a kubeconfig flag to specify kubeconfig file location #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,14 @@ This above command will:

### `print` command

| Flag | Default Value | Required | Description |
| -------------- | ----------------------- | -------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| namespace | | No | If present, the namespace scope for the invocation |
| all-namespaces | False | No | If present, list the requested object(s) across all namespaces. Namespace in the current context is ignored even if specified with --namespace |
| output | yaml | No | The output format, either yaml or json |
| input_file | | No | Path to the manifest file. When set, the tool will read ingresses from the file instead of reading from the cluster. Supported files are yaml and json |
| Flag | Default Value | Required | Description |
| -------------- | ----------------------- | -------- | ------------------------------------------------------------ |
| namespace | | No | If present, the namespace scope for the invocation |
| all-namespaces | False | No | If present, list the requested object(s) across all namespaces. Namespace in the current context is ignored even if specified with --namespace |
| output | yaml | No | The output format, either yaml or json |
| input_file | | No | Path to the manifest file. When set, the tool will read ingresses from the file instead of reading from the cluster. Supported files are yaml and json |
| providers | all supported providers | No | Comma-separated list of providers. If present, the tool will try to convert only resources related to the specified providers. Otherwise it will default to all the supported providers |
| kubeconfig | | No | The kubeconfig file to use when talking to the cluster. If the flag is not set, a set of standard locations can be searched for an existing kubeconfig file. |

## Conversion of Ingress resources to Gateway API

Expand Down
4 changes: 0 additions & 4 deletions cmd/print.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,3 @@ func getNamespaceInCurrentContext() (string, error) {

return currentNamespace, err
}

func init() {
rootCmd.AddCommand(newPrintCommand())
}
26 changes: 23 additions & 3 deletions cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,32 @@ import (
"github.com/spf13/cobra"
)

var rootCmd = &cobra.Command{
Use: "ingress2gateway",
Short: "Convert Ingress manifests to Gateway API manifests",
// kubeconfig indicates kubeconfig file location.
var kubeconfig string

func newRootCmd() *cobra.Command {
rootCmd := &cobra.Command{
Use: "ingress2gateway",
Short: "Convert Ingress manifests to Gateway API manifests",
PersistentPreRun: func(cmd *cobra.Command, args []string) {
getKubeconfig()
},
}

rootCmd.PersistentFlags().StringVar(&kubeconfig, "kubeconfig", "",
`The kubeconfig file to use when talking to the cluster. If the flag is not set, a set of standard locations can be searched for an existing kubeconfig file.`)
return rootCmd
}

func getKubeconfig() {
if kubeconfig != "" {
os.Setenv("KUBECONFIG", kubeconfig)
}
}

func Execute() {
rootCmd := newRootCmd()
rootCmd.AddCommand(newPrintCommand())
err := rootCmd.Execute()
if err != nil {
os.Exit(1)
Expand Down