Skip to content

fix: weight can not set to 0 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 2 commits into from
Apr 7, 2024
+74 −1
Merged

fix: weight can not set to 0 #137

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e255011
fix: weight can not set to 0
MregXN Feb 28, 2024
6d45ccd
add unit tests
MregXN Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/i2gw/providers/ingressnginx/canary.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func calculateBackendRefWeight(paths []ingressPath) ([]gatewayv1.HTTPBackendRef,
errors = append(errors, err)
continue
}
if path.extra != nil && path.extra.canary != nil && path.extra.canary.weight != 0 {
if path.extra != nil && path.extra.canary != nil && path.extra.canary.enable == true {
weight := int32(path.extra.canary.weight)
backendRef.Weight = &weight
totalWeightSet += weight
Expand Down
3 changes: 3 additions & 0 deletions pkg/i2gw/providers/ingressnginx/canary_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ func Test_ingressRuleGroup_calculateBackendRefWeight(t *testing.T) {
},
},
extra: &extra{canary: &canaryAnnotations{
enable: true,
weight: 101,
}},
},
Expand Down Expand Up @@ -82,6 +83,7 @@ func Test_ingressRuleGroup_calculateBackendRefWeight(t *testing.T) {
},
},
extra: &extra{canary: &canaryAnnotations{
enable: true,
weight: 30,
}},
},
Expand Down Expand Up @@ -116,6 +118,7 @@ func Test_ingressRuleGroup_calculateBackendRefWeight(t *testing.T) {
},
},
extra: &extra{canary: &canaryAnnotations{
enable: true,
weight: 50,
weightTotal: 200,
}},
Expand Down