added notifications for apisix provider #176
added notifications for apisix provider #176k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
|
Hi @Devaansh-Kumar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
d0a6a30 to
04042a3
Compare
04042a3 to
0457e59
Compare
0457e59 to
87679de
Compare
mlavacca
left a comment
There was a problem hiding this comment.
Thanks, @Devaansh-Kumar, I'll leave the final lgtm to @LiorLieberman
/approve
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Devaansh-Kumar, LiorLieberman, mlavacca The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds notifications for conversion of Apisix provider
Which issue(s) this PR fixes:
This pull request addresses part of the issue described in #131
Does this PR introduce a user-facing change?:
/cc @mlavacca @LiorLieberman